Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils,types): add registerUsages for promotions + computeActions consider usage #6094

Merged
merged 18 commits into from
Jan 16, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 15, 2024

RESOLVES CORE-1639
RESOLVES CORE-1640
RESOLVES CORE-1634

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:55pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 7:55pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 7:55pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 7:55pm

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 00d2b12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/types Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan marked this pull request as ready for review January 15, 2024 18:51
@riqwan riqwan requested a review from a team as a code owner January 15, 2024 18:51
Base automatically changed from feat/campaign-promotion to develop January 16, 2024 08:38
@olivermrbl
Copy link
Contributor

Please resolve conflicts and fix tests 💯

@riqwan
Copy link
Contributor Author

riqwan commented Jan 16, 2024

@olivermrbl resolved & fixed

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strong work @riqwan 🏎️

Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
@riqwan riqwan changed the title feat(utils,types): add registerUsages for promotion's computed actions feat(utils,types): add registerUsages for promotions + computeActions consider usage Jan 16, 2024
* chore: added compute action usage check

* chore: add more specs
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riqwan riqwan requested a review from a team as a code owner January 16, 2024 19:54
@kodiakhq kodiakhq bot merged commit 68ddd86 into develop Jan 16, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the feat/register-usage branch January 16, 2024 20:06
This was referenced Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants