Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa,types): add promotion list/get endpoint #6110

Merged
merged 16 commits into from
Jan 18, 2024
Merged

feat(medusa,types): add promotion list/get endpoint #6110

merged 16 commits into from
Jan 18, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 17, 2024 •
edited
Loading

what:

  • adds get promotion endpoint (RESOLVES CORE-1677)
  • adds list promotions endpoint (RESOLVES CORE-1676)
  • uses new API routes

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 3:42pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:42pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:42pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:42pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ac04047

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan force-pushed the feat/promotion-list-endpoint branch from 2bbd62d to 0876a84 Compare January 17, 2024 09:24
@riqwan riqwan marked this pull request as ready for review January 17, 2024 09:25
@riqwan riqwan requested review from a team as code owners January 17, 2024 09:25
adrien2p
adrien2p approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

packages/medusa/src/api/routes/admin/promotions/list-promotions.ts Outdated Show resolved Hide resolved
@adrien2p
Copy link
Member

Could you just add a description to the pr for the changelog please 💪

olivermrbl
olivermrbl requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: If we can, we should use the new API Routes. Did you try that?

@adrien2p
Copy link
Member

todo: If we can, we should use the new API Routes. Did you try that?

The new API is not supported by the core @olivermrbl, it goes through a separated loader etc

@olivermrbl
Copy link
Contributor

todo: If we can, we should use the new API Routes. Did you try that?

The new API is not supported by the core @olivermrbl, it goes through a separated loader etc

Yeah – maybe now is a good time to revisit and gauge how much effort it would require to support it, wdyt?

@riqwan riqwan force-pushed the feat/promotion-list-endpoint branch from 5c220a8 to eb644e7 Compare January 17, 2024 16:30
@riqwan riqwan changed the title feat(medusa,types): add promotion list endpoint feat(medusa,types): add promotion list/get endpoint Jan 17, 2024
olivermrbl
olivermrbl reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean 😻

Left a couple of questions

packages/medusa/src/loaders/api.ts Outdated Show resolved Hide resolved
packages/medusa/src/loaders/api.ts Outdated Show resolved Hide resolved
adrien2p
adrien2p approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work man 🔥 last couple of comments from oli to discuss

packages/medusa/src/api/routes/admin/promotions/[id]/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/routes/admin/promotions/middlewares.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/routes/admin/promotions/validators.ts Outdated Show resolved Hide resolved
@riqwan riqwan force-pushed the feat/promotion-list-endpoint branch from d6c7ee1 to d6410de Compare January 18, 2024 13:46
@kodiakhq kodiakhq bot merged commit a12c28b into develop Jan 18, 2024
16 checks passed
This was referenced Jan 18, 2024
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @adrien2p @olivermrbl