CI: Add cloudrun deploy script #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spowelljr
changed the title
medyagh
reviewed
Aug 11, 2023
Dockerfile.dbbrowser
Outdated
| COPY pkg ./pkg | ||
| RUN CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -o /dbbrowser | ||
|
|
||
| FROM alpine:3 |
There was a problem hiding this comment.
this could probably be from Scratch instead of alpine, no ?
There was a problem hiding this comment.
I have to do RUN apk add --no-cache ca-certificates, I don't think scratch supports that, I'll double check though
There was a problem hiding this comment.
Yeah, it fails without alpine, and if you don't run that command you get an error when the apps starting
tls: failed to verify certificate: x509: certificate signed by unknown authority cloudrun
medyagh
requested changes
Aug 11, 2023
| @@ -0,0 +1,14 @@ | |||
| FROM golang:1.21 AS builder | |||
There was a problem hiding this comment.
lets add this to gha action to push this image too
simmilar to the binary image
https://hub.docker.com/repository/docker/medyagh/gopogh/general
https://github.com/medyagh/gopogh/blob/master/.github/workflows/image_build.yml
medyagh
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.