Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements : Add custom urls, add open source libraries information #1

Closed
benju69 opened this issue Apr 22, 2016 · 6 comments
Closed

Comments

@benju69
Copy link

benju69 commented Apr 22, 2016

No description provided.

@medyo
Copy link
Owner

medyo commented Apr 22, 2016

Hi @benju69,

What do you mean by 'custom urls', because the current version supports custom url intents ?

@Souf-R
Copy link

Souf-R commented Apr 22, 2016

Hi @medyo

I think it would be better to use a list of pairs (library name, library URL) like the way Trello is doing it in its About page.
Is this what you mean @benju69 ?

@rfgamaral
Copy link

Yes! I always credit all the third-party libraries I use on my apps on the About page, it's the least we can do for those developers. And this project is actually a perfect example. It's open-source and we can't even credit it properly.

Please consider this issue for a future version.

@medyo
Copy link
Owner

medyo commented Apr 23, 2016

Okay Guys,

Well android-about-page was made in a generic way to let developers the full freedom to plug whatever views they like.

To mention third-party libraries, there are many libraries solving exactly this point like :

You could easily add a row Open source libraries and point it the right activity which implement one of libraries mentioned above.

If you'd like to stick with my library, you could also archieve the same result by doing something like :

AboutPage aboutPage = new AboutPage(this);
aboutPage.addGroup("Open Source libraries");

HashMap<String, String> librariesList = new HashMap<>();
librariesList.put("Fancy Buttons", "https://github.com/medyo/Fancybuttons");
librariesList.put("Once", "https://github.com/jonfinerty/Once");
librariesList.put("Android Iconics", "https://github.com/mikepenz/Android-Iconics");

for (Map.Entry<String, String> lib : librariesList.entrySet()) {
    Element libElement = new Element();
    libElement.setTitle(lib.getKey());

    Intent libIntent = new Intent(Intent.ACTION_VIEW,Uri.parse(lib.getValue()));
    libElement.setIntent(libIntent);

    aboutPage.addItem(libElement);
}

View viewAboutPage = aboutPage.create();

Open Source Libraries

@medyo
Copy link
Owner

medyo commented Apr 24, 2016

I'll close this issue, if you've any other questions, just reopen

Thanks

@medyo medyo closed this as completed Apr 24, 2016
@benju69
Copy link
Author

benju69 commented Apr 25, 2016

Ok cool :) Thanks for the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants