test_return_geoip_object fails as new geoip tests if database is not corrupt #250
Labels
Comments
|
I'm packaging txtorcon for a distro and this causes problems. Would like to see it solved or is there a workaround? Is it safe to just skip the failing test? |
|
@jluttine You can just skip the failing test. The problem is that the GeoIP library now validates that the database is valid before giving you an object back but in the test case, it is not valid, so will always fail. A fixed test case would provide a valid database. |
jluttine
added a commit
to jluttine/nixpkgs
that referenced
this issue
Feb 10, 2018
There is a bug in the upstream package that causes one test to fail currently: meejah/txtorcon#250 The test can be safely ignored but should be enabled once it's been fixed upstream.
8 tasks
|
This test is still broken in 19.0.0. |
Merged
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this issue
May 16, 2020
v20.0.0: I'm pleased to announce txtorcon 20.0.0. This fixes a few bugs and officially deprecates Python 2 support. * Use real GeoIP database or nothing (meejah/txtorcon#250) * Change abstract base classes import in preperation for Python 3.8 * Python 3.4 is no longer supported * Python 2 is deprecated; all new code should be Python 3. Support for Python 2 will be removed in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new test can be seen at:
http://sources.debian.net/src/geoip/1.6.11-2/libGeoIP/GeoIP.c/#L1202
This didn't exist a couple of minor releases ago, but the test will now fail as it's being given an empty file, not a valid database.
The text was updated successfully, but these errors were encountered: