Trying to fix bug that affects projected counts #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoos
added a commit
to meelgroup/mccomp-2022
that referenced
this pull request
Jul 16, 2022
|
Merging because we can't have buggy released code and @smsharma1 couldn't respond in time to the issue or the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix bug in issue #16 It's been hacked together by Kuldeep very quickly, I'm checking it overnight. @smsharma1 can you please check if this makes sense? And can you please check if it doesn't affect the non-projected model count?
Thanks,
Mate