Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [!] Error status #154

Merged
merged 2 commits into from
May 14, 2023
Merged

Add [!] Error status #154

merged 2 commits into from
May 14, 2023

Conversation

P3run
Copy link
Contributor

@P3run P3run commented Mar 24, 2023

Changes:

  1. Introduced a new status: [!] Error.
  2. Changed the colour of [x] Rate Limit to yellow as [!] Error is now red.
  3. [!] Error is now returned by default if not set otherwise in the module.
  4. The "error" flag in the result object is optional so it is not necessary to update existing modules and set it to False.

@mark-sercombe
Copy link
Contributor

Great! I will hopefully start implementing it in the modules soon

@P3run
Copy link
Contributor Author

P3run commented Mar 28, 2023

Oh, I think that @megadose needs to approve and merge it first. That's why I haven't touched my other pull requests yet.

@megadose megadose merged commit 2b6868f into megadose:master May 14, 2023
@P3run P3run deleted the error_handling branch June 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants