feat: Add SOFARPC Framework Plugin Support #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oewang
commented
Feb 16, 2023
oewang
commented
- Support for collecting client-to-server traces
- Supports collecting the following metrics for the method dimension: number of calls, number of failures, minimum, average, maximum execution time, etc.
- Support for SOFARPC framework greater than or equal to version 5.3.0
- Support for collecting client-to-server traces - Supports collection of the following metrics in the method dimension: number of calls, number of failures, minimum, average, maximum execution time, etc.
- Comment meter type and timer type metric assertions
landyking
reviewed
Feb 20, 2023
...agent/plugin/sofarpc/interceptor/trace/future/SofaRpcResponseFutureTraceInterceptorTest.java
Show resolved
Hide resolved
- Modify check errors - Add comments to the methods in the `SofaRpcCtxUtil` class
- Change `method` label name to `interface` label name - Change related metrics docs
...t/plugin/sofarpc/interceptor/trace/callback/SofaRpcResponseCallbackTraceInterceptorTest.java
Outdated
Show resolved
Hide resolved
...agent/plugin/sofarpc/interceptor/trace/future/SofaRpcResponseFutureTraceInterceptorTest.java
Outdated
Show resolved
Hide resolved
…farpc/interceptor/trace/callback/SofaRpcResponseCallbackTraceInterceptorTest.java Co-authored-by: yufu.deng <954068039@qq.com>
…farpc/interceptor/trace/future/SofaRpcResponseFutureTraceInterceptorTest.java Co-authored-by: yufu.deng <954068039@qq.com>
observeralone
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.