Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience for XP for each 2 rolled on an unsuccessful task can not be negative #47

Closed
scJazz2 opened this issue Apr 9, 2016 · 5 comments
Labels

Comments

@scJazz2
Copy link

scJazz2 commented Apr 9, 2016

I don't know exactly when it happened but it used to be a value that could be negative. Now it can not be negative.

@Dylan-M
Copy link
Contributor

Dylan-M commented Apr 10, 2016

I'm not even sure why you'd want it to be negative. Even in real life you learn more from failure than you do from success.

@scJazz2
Copy link
Author

scJazz2 commented Apr 10, 2016

I don't know either since I set that value to ZERO 2 years ago. However, it used to be able to be a signed integer.

@Akjosch
Copy link
Contributor

Akjosch commented Apr 24, 2016

Well, the "easy" fix breaks a few things (a few places in code expect the total XP to never go below 0). Though that particular bug seems to have been in there forever, it's just that nobody realised it's there ...

@Dylan-M Dylan-M changed the title BUG: Experience for XP for each 2 rolled on an unsuccessful task can not be negative Experience for XP for each 2 rolled on an unsuccessful task can not be negative Oct 2, 2016
@Dylan-M
Copy link
Contributor

Dylan-M commented Oct 2, 2016

I'm going to close this as invalid, as people shouldn't lose experience just for failing at a task.

@Dylan-M Dylan-M closed this as completed Oct 2, 2016
@scJazz2
Copy link
Author

scJazz2 commented Oct 2, 2016

I agree... it was a bad suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants