WIP: #SDK-822. Nodes on demand #2114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid to add nodes in table statecache
With these methods we can load node on demand
Avoid to Db at the end of initsc and updatesc Keep in memory only ROOTNODE, RUBBISHNODE and INCOMINGNODE
We keep in memory when it's received by putNode command or if its parent is in memory Avoid to make extra operation with nodes that they are going to be removed immediately
Add comment about possible nodes on demand improvement
In this way, we have available all node children althoug they aren't saved in db yet. They are save in notify
sergiohs84
reviewed
Dec 1, 2020
src/db/sqlite.cpp
Outdated
Comment on lines
517
to
521
| if (data && size) | ||
| { | ||
| node.mNode = std::string(static_cast<const char*>(data), size); | ||
| nodes[nodeHandle] = node; | ||
| } |
There was a problem hiding this comment.
What if data or size are invalid? Perhaps we should:
Suggested change
| if (data && size) | |
| { | |
| node.mNode = std::string(static_cast<const char*>(data), size); | |
| nodes[nodeHandle] = node; | |
| } | |
| if (!data || !size) | |
| { | |
| break; | |
| } | |
| node.mNode = std::string(static_cast<const char*>(data), size); | |
| nodes[nodeHandle] = node; |
There was a problem hiding this comment.
After some revamping, the comment still applies to the new code. Here: https://github.com/meganz/sdk/pull/2114/files#diff-3b04aacea1f78e0fa172c102fee7bb594ad269aae296e8f82ee92081b2ee5796R578
src/megaclient.cpp
Outdated
| } | ||
|
|
||
| std::map<handle, NodeSerialized> nodeMap; | ||
| sctable->getChildrenFromNode(node->nodehandle, nodeMap); |
There was a problem hiding this comment.
Should we, at least, log a message if the method returns false? (something went wrong)
There was a problem hiding this comment.
Refactorize `shareOrLink_t` and fix the case where a folder link can be taken as an outgoing share
Unused variables, castings from `size_t` to `int` and other minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.