Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mouse buttons uses bitwise logic, so these values should be like 0, 1, 2, 4, 8, and so on, not like 0, 1, 2, 3, 4, 5, 6, 7, 8, and so on.
Behaviour
Actual
As an example, MouseMidButton was the same as pressing MouseLeftButton + MouseRightButton at the same time. Because MouseLeftButton (1) + MouseRightButton (2) = MouseMidButton (3). It means, if I check in my code if I'm pressing mid button
g_window.isPressed(MouseMidButton)
, it will work with mid button, but ALSO if I click left+right buttons.Expected
If I check like
g_window.isPressed(MouseMidButton)
, it should not consider this as true if I click left+right buttons.Type of change
Please delete options that are not relevant.
How Has This Been Tested
true
, but it should be false instead, since you are not pressing the mid button.Test Configuration:
Checklist