Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: walking issue #560 #562

Merged
merged 9 commits into from
Jul 19, 2023
Merged

fix: walking issue #560 #562

merged 9 commits into from
Jul 19, 2023

Conversation

mehah
Copy link
Owner

@mehah mehah commented Jul 7, 2023

No description provided.

@LeoTKBR
Copy link

LeoTKBR commented Jul 7, 2023

@mehah
this was the result, the stopped running bug was fixed but it seems to be stuck before going to the second step, follow the attached gif

GIF:
https://imgur.com/WWq41w4

@mehah
Copy link
Owner Author

mehah commented Jul 7, 2023

@LeoTKBR
try now

@LeoTKBR
Copy link

LeoTKBR commented Jul 8, 2023

@LeoTKBR try now

@mehah it hasn't changed, it's still giving the same result as before

@mehah
Copy link
Owner Author

mehah commented Jul 8, 2023

@LeoTKBR
try again :D

@LeoTKBR
Copy link

LeoTKBR commented Jul 8, 2023

@mehah

This was the result, it seems that the part that is "tangled" was corrected, however, it has spasms in the outfit

GIF:
https://imgur.com/P0PVTfa

@mehah
Copy link
Owner Author

mehah commented Jul 10, 2023

@LeoTKBR
test again, unfortunately I can not test, this only occurs in your client.

@LeoTKBR
Copy link

LeoTKBR commented Jul 10, 2023

@LeoTKBR test again, unfortunately I can not test, this only occurs in your client.
@mehah
it still has a problem apparently the result of screwing it was removed however a problem returned when going up the stairs the next step is invisible and the character is in the previous square and when going up the stairs from another position it is stuck as in the GIF attached, I decided to upload it the changes in a commit where only mine was changed (src) of course there are some other changes and I also updated in its most recent version so the 55 differences that's it I ended up forgetting to update the fork before creating the branch.

Commit:
LeoTKBR@4f0ac3e

GIF:
Walking-Fix

@mehah
Copy link
Owner Author

mehah commented Jul 10, 2023

there really is nothing else to do, if I don't have an environment where I can simulate the problem, I can't fix it, this is a specific problem with your sprite/client.

@LeoTKBR
Copy link

LeoTKBR commented Jul 10, 2023

there really is nothing else to do, if I don't have an environment where I can simulate the problem, I can't fix it, this is a specific problem with your sprite/client.

this is strange because as much as it is "different" it follows the same pattern as an 8.6 outfit with 3 sprites for each direction counting the stopped direction, that is the same result would happen on an 8.6 server or that uses the same amount of sprites per outfit....

@mehah
Copy link
Owner Author

mehah commented Jul 10, 2023

there really is nothing else to do, if I don't have an environment where I can simulate the problem, I can't fix it, this is a specific problem with your sprite/client.

this is strange because as much as it is "different" it follows the same pattern as an 8.6 outfit with 3 sprites for each direction counting the stopped direction, that is the same result would happen on an 8.6 server or that uses the same amount of sprites per outfit....

yeah, but it's working as it should for 7.2, 8.6, 1098 and 12xx

@LeoTKBR
Copy link

LeoTKBR commented Jul 10, 2023

yeah, but it's working as it should for 7.2, 8.6, 1098 and 12xx

Are you sure about that, I'll take a base 8.6 0.4 and confirm and return with the results

@LeoTKBR
Copy link

LeoTKBR commented Jul 10, 2023

@mehah
this was the result of an 8.6 server in this case I will attach its source below

GIF:
TibiaWalking

Source:
https://forums.otserv.com.br/index.php?/forums/topic/169504-%C2%A0teamwarot-hardcore-86-team-vs-team/

@mehah
Copy link
Owner Author

mehah commented Jul 10, 2023

now i understand, because i know tibia sprites and yours no, this problem started to happen in this PR, i will check here.

@mehah
Copy link
Owner Author

mehah commented Jul 11, 2023

@LeoTKBR
try again

@LeoTKBR
Copy link

LeoTKBR commented Jul 11, 2023

@mehah
Well, even though visually it is tangled, it is smooth on the floor now the question is if this is normal or do you still need to make some adjustments to correct it

GIF:
Walking-Fix

@mehah
Copy link
Owner Author

mehah commented Jul 12, 2023

@LeoTKBR
you tested it on 8.6, if this problem didn't occur, then it's something on your server, probably the formula.

@mehah mehah merged commit aa1bec1 into main Jul 19, 2023
@mehah mehah deleted the fix_walking_issue branch July 19, 2023 01:03
dudantas pushed a commit that referenced this pull request Nov 17, 2023
When a player tries to remove any item from non-invited house door.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants