Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: character list window #602

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat: character list window #602

merged 3 commits into from
Oct 27, 2023

Conversation

majestyotbr
Copy link
Collaborator

@majestyotbr majestyotbr commented Oct 19, 2023 •
edited
Loading

characterlist

@majestyotbr majestyotbr marked this pull request as draft October 19, 2023 21:20
@majestyotbr majestyotbr marked this pull request as ready for review October 19, 2023 22:43
@luanluciano93

This comment was marked as resolved.

Sign in to view
@majestyotbr majestyotbr force-pushed the characterlist branch 3 times, most recently from 3622823 to ce952ce Compare October 20, 2023 17:40
@Nottinghster
Copy link
Collaborator

It should work with all client versions, not working with 860

image

@marcosvf132
Copy link
Contributor

marcosvf132 commented Oct 23, 2023 •
edited
Loading

It should work with all client versions, not working with 860

image

Not, it shouldnt. The structure of the login on 12+ client is completely different from the 11- clients.
The QT client (12+) get the characterlist and initial messages throught HTTP POST, using the login.php from your AAC.
The old client (11-) get the characterlist from the server protocollogin.

If you want this feature to work on all clients version perfectly you must change your protocollogin structure to include characters appearances.

By default the only data that comes from the server protocollogin is the character name, server name, server IP, game Port and premium days.

Repository owner deleted a comment from Vysius Oct 23, 2023
@majestyotbr

This comment was marked as resolved.

Sign in to view
@majestyotbr majestyotbr marked this pull request as draft October 23, 2023 10:25
@Nottinghster

This comment was marked as resolved.

Sign in to view
@majestyotbr

This comment was marked as resolved.

Sign in to view
@Nottinghster

This comment was marked as resolved.

Sign in to view
@majestyotbr

This comment was marked as resolved.

Sign in to view
@majestyotbr

This comment was marked as resolved.

Sign in to view
@Nottinghster

This comment was marked as resolved.

Sign in to view
@majestyotbr majestyotbr marked this pull request as ready for review October 25, 2023 06:19
@majestyotbr majestyotbr merged commit 23e0626 into mehah:main Oct 27, 2023
10 checks passed
@majestyotbr majestyotbr deleted the characterlist branch October 27, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Costallat Costallat Costallat approved these changes

@mehah mehah mehah approved these changes

@luanluciano93 luanluciano93 luanluciano93 approved these changes

@elsongabriel elsongabriel elsongabriel approved these changes

@lgrossi lgrossi lgrossi approved these changes

Assignees
No one assigned
Labels
Area: Datapack Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@majestyotbr @luanluciano93 @Nottinghster @marcosvf132 @Costallat @mehah @elsongabriel @lgrossi