fix: use port for http login and allow custom URL #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
changed the title
added 7 commits
November 1, 2023 03:27
investigating more details to improve the fix Signed-off-by: Renato Foot <renato@foot.br>
Signed-off-by: Renato Foot <renato@foot.br>
Signed-off-by: Renato Foot <renato@foot.br>
Signed-off-by: Renato Foot <renato@foot.br>
Remove hard coded login.php from URL to allow custom URLs. Signed-off-by: Renato Foot <renato@foot.br>
Fix to split the URL without the port and append the port on the right place. Signed-off-by: Renato Foot <renato@foot.br>
- Get full URL path - Check and accept URL without port Signed-off-by: Renato Foot <renato@foot.br>
Costallat
force-pushed
the
fix-http-login-port-not-being-used
branch
from
96d7eb6
to
930610e
Compare
Costallat
changed the title
dudantas
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
majestyotbr
approved these changes
Nov 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the HTTP login it is not using the port field, so we had to add the port on the IP address, with this change it will now get the port from the port field that we have on the login screen.
Updated code to also allow custom login URLs.
Behavior
Actual
Doesn't use the port field when making logon through HTTP.
Doesn't allow to customize the login URL, always append login.php on the URL.
Expected
Use the port specified on the port field.
Allow customized URL, 'myserver.com/api/login/endpoint', will be 'myserver.com:/api/login/endpoint'
Fixes
Start to use the port field and avoid that we have to add the port together with the IP/URL of the server. Also make the default port if not specified the port 80, the default HTTP port.
Allow to have customized login URLs.
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Tested removing the port fro the IP address and added it to the port field. Also saw that when not setting the port it is using the port 80.
Checklist