build: add shellapi and timeapi includes to fix visual studio solution #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to build on certain Windows 10 versions through the SLN file from Visual Studio, you will encounter some 'identifier not found' errors.
Behaviour
Actual
When following the compilation tutorial you shouldn't have any issues compiling.
Expected
Errors out on some identifiers in the
framework/platform/win32platform.cpp
andframework/platform/win32window.cpp
files as can be seen aboveFixes
Added
#include <timeapi.h>
inframework/platform/win32window.cpp
.Added
#include <shellapi.h>
inframework/platform/win32platform.cpp
.Type of change
Please delete options that are not relevant.
How Has This Been Tested
Attempted to build as was described in the documentation and got the error. Once the fix is implemented, project compiles successfully
Checklist