Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add shellapi and timeapi includes to fix visual studio solution #611

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

Giorox
Copy link
Contributor

@Giorox Giorox commented Oct 31, 2023

Description

When trying to build on certain Windows 10 versions through the SLN file from Visual Studio, you will encounter some 'identifier not found' errors.

image

Behaviour

Actual

When following the compilation tutorial you shouldn't have any issues compiling.

Expected

Errors out on some identifiers in the framework/platform/win32platform.cpp and framework/platform/win32window.cpp files as can be seen above

Fixes

Added #include <timeapi.h> in framework/platform/win32window.cpp.
Added #include <shellapi.h> in framework/platform/win32platform.cpp.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Attempted to build as was described in the documentation and got the error. Once the fix is implemented, project compiles successfully

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

…not found' errors when compiling through the SLN on Windows
@majestyotbr majestyotbr changed the title Added headers that fixes the 'identifier not found' errors when compiling through the SLN on Windows build: add timeapi and shellapi includes to fix visual studio solution Oct 31, 2023
@majestyotbr majestyotbr changed the title build: add timeapi and shellapi includes to fix visual studio solution build: add shellapi and timeapi includes to fix visual studio solution Oct 31, 2023
@mehah mehah merged commit 050d29c into mehah:main Nov 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants