Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GameCountU16 #618

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Fix: GameCountU16 #618

merged 3 commits into from
Nov 5, 2023

Conversation

IcaroPimentel654
Copy link
Contributor

@IcaroPimentel654 IcaroPimentel654 commented Nov 5, 2023

Description

item max count was limited to uint8_t, when you have uint16 on server.
When players had more than 255 items, the count as reseting to 1, so was not correct.

Behaviour

Actual

when you have more than 255 items on stack, it will reset the count, following uint8_t

Expected

when you have more than 255 items on stack, it will no more reset the count on client, it will follow uint16_t feature.

Fixes

# GameCountU16 max count

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [X ] i created more than 255 itens and it worked.

Test Configuration:

  • Server Version: 0.3.6
  • Client: 8.54
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

item max count was limited to uint8, when you have uint16 on server.
@SkullzOTS SkullzOTS merged commit 7da55d9 into mehah:main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants