Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android build #639

Merged
merged 6 commits into from
Nov 28, 2023
Merged

fix: android build #639

merged 6 commits into from
Nov 28, 2023

Conversation

SkullzOTS
Copy link
Collaborator

No description provided.

@majestyotbr majestyotbr changed the title Fix android build fix: android build Nov 23, 2023
@Zbizu
Copy link
Contributor

Zbizu commented Nov 23, 2023

obraz

build successful (rest of content of my comment may be moved to a new issue as this PR solves the compilation problem itself)

test 1: Pixel 4 XL API 28 (emulated)
application crashed on weblogin attempt to fetch character list (protocol 13.20)

10.98 protocol: using address 10.0.2.2 (local pc address for emulator), port 7171
got into character list, attempt to login character ended with this:
obraz

test2: connected physical device - Motorola Moto Z3 Play (Android 9), 10.98 has same issue - character list working, login failing (didn't test 13.20 + weblogin) / connection method: wi-fi + PC address (192.168.x.x)

test 3: Windows 10 PC, exe compiled in Visual Studio as Release x64 (to be sure that it's android issue) - 10.98 login worked fine / connection method: localhost (127.0.0.1) - conclusion: needs more testers, could be firewall configuration issue on my PC

@mehah mehah merged commit 67ff317 into main Nov 28, 2023
6 of 10 checks passed
@mehah mehah deleted the fixAndroidBuild branch November 28, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants