GHA: Update Docker and Ubuntu workflows #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2023 17:40
- Remove duplicated entry (again, don't know why it got back after PR that fixed this) - Added entry for cmake files Signed-off-by: Renato Foot <renato@foot.br>
- Removed not used GitVersion - Update ubuntu build workflow Removed ccache that will not work with UNITY and PCH. - Disabled UNITY and PCH for debug images and enabled more warning flags This will make it show these warnings on the PR. Signed-off-by: Renato Foot <renato@foot.br>
Using newer versions of the actions helped cleaning the workflow, now it is smaller and easier to understand. Signed-off-by: Renato Foot <renato@foot.br>
Costallat
requested review from
conde2,
mehah,
dudantas,
majestyotbr and
beats-dh
Costallat
changed the title
Also do not upload artifacts when building PR as it failing and we need to re-run the build Signed-off-by: Renato Foot <renato@foot.br>
mehah
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and clean the Ubuntu and Docker workflows. Using newer versions of the actions allows to use new features and remove old workarounds.