Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse packets for protocol 13.20 #683

Merged
merged 5 commits into from
Dec 24, 2023
Merged

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Dec 20, 2023

Description

This PR corrects inaccuracies in 13.20 protocol.

Behaviour

Actual

parsing these packets causes otc to desync and show errors in terminal

Expected

handle the packets the same way as vanilla (rl) client

Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Connecting to local testserver and checking terminal.

Server was running with vanilla client for several months and the features were used by hundreds of players so I have full confidence in server side protocol being correct.

Test Configuration:

  • Server Version: Kitsune 2.0 (an engine used in Noveria, built for vanilla 13.20 client)
  • Client: 13.20
  • Operating System: Windows 10 (client)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Zbizu Zbizu changed the title Add missing packets for protocol 13.20 Fix inaccuracies in protocol 13.20 Dec 20, 2023
@majestyotbr majestyotbr changed the title Fix inaccuracies in protocol 13.20 fix: parse packets for protocol 13.20 Dec 21, 2023
@conde2 conde2 merged commit 01da41c into mehah:main Dec 24, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants