fix: parse packets for protocol 13.20 #683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects inaccuracies in 13.20 protocol.
Behaviour
Actual
parsing these packets causes otc to desync and show errors in terminal
Expected
handle the packets the same way as vanilla (rl) client
Fixes
Type of change
How Has This Been Tested
Connecting to local testserver and checking terminal.
Server was running with vanilla client for several months and the features were used by hundreds of players so I have full confidence in server side protocol being correct.
Test Configuration:
Checklist