Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ToolstipsV8 for inventory items #740

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

kokekanon
Copy link
Contributor

@kokekanon kokekanon commented Apr 12, 2024

Creditos : kondra , v8team

Many people asked for it on Discord. I'm not sure if it'll be approved, but it'll be helpful for more than one person.

image

server conections:

option 1: 1.5 8.6
moviebr/TFS-1.5-Downgrades@d978ead

option 2: 1.3 ? 10.98
OTCv8/forgottenserver@7f5b4fb

optiones 3 : 0.4
cc: @ thalesduarte help

option 4 : canary

option 5: 1.4.2 repo otland
kokekanon/TFS-1.4.2-Compatible-Aura-Effect-Wings-Shader-MEHAH@7764f37


void ProtocolGame::onRecvFirstMessage(NetworkMessage& msg)
.... 
	if (operatingSystem == CLIENTOS_OTCLIENT_WINDOWS) {
		isMehah = true;
	}
	

Important

Active features OTC
g_game.enableFeature(GameItemTooltipV8);

PD: I'm not good at CPP.

image

Issues addressed:
image

image

image

image

@DoktorHolzbein
Copy link
Contributor

Tested and working
I've used the TFS 1.4.2 changes for that

@Fischturd
Copy link

Amazing work, works well with 1.4.2, thanks for assisting with the changes there!

@luanluciano93
Copy link
Collaborator

Shouldn't setTooltip be within condition if self:getItem() and self:getItem():getTooltip():len() > 0 then? What happens if tooltip is null?

@kokekanon
Copy link
Contributor Author

kokekanon commented Apr 18, 2024

Shouldn't setTooltip be within condition if self:getItem() and self:getItem():getTooltip():len() > 0 then? What happens if tooltip is null?

I think that .

image
is simply not displayed

I could change it to "" ,
but in v8 it has nil

@luanluciano93
Copy link
Collaborator

 if self:getItem() and self:getItem():getTooltip():len() > 0 then
            self:setTooltip(splitTextIntoLines(self:getItem():getTooltip(), 80))
 end

wouldn't that solve it?

@luanluciano93 luanluciano93 merged commit 0c03ef9 into mehah:main Apr 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants