-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ToolstipsV8 for inventory items #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and working |
DoktorHolzbein
approved these changes
Apr 12, 2024
kokekanon
commented
Apr 12, 2024
Amazing work, works well with 1.4.2, thanks for assisting with the changes there! |
Nottinghster
approved these changes
Apr 17, 2024
Shouldn't |
if self:getItem() and self:getItem():getTooltip():len() > 0 then
self:setTooltip(splitTextIntoLines(self:getItem():getTooltip(), 80))
end wouldn't that solve it? |
Nottinghster
approved these changes
Apr 20, 2024
luanluciano93
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creditos : kondra , v8team
Many people asked for it on Discord. I'm not sure if it'll be approved, but it'll be helpful for more than one person.
server conections:
option 1: 1.5 8.6
moviebr/TFS-1.5-Downgrades@d978ead
option 2: 1.3 ? 10.98
OTCv8/forgottenserver@7f5b4fb
optiones 3 : 0.4
cc: @ thalesduarte help
option 4 : canary
option 5: 1.4.2 repo otland
kokekanon/TFS-1.4.2-Compatible-Aura-Effect-Wings-Shader-MEHAH@7764f37
Important
Active features OTC
g_game.enableFeature(GameItemTooltipV8);
PD: I'm not good at CPP.
Issues addressed: