Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [game_entergame] loadBox in old protocol #743

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

kokekanon
Copy link
Contributor

The modification made to #736 of loadBox was in the wrong place in the code. causes display loadBox in old protocols.

fix: [game_entergame] loadBox in old protocol 3168283

currently

bandicam.2024-04-17.18-40-37-552.mp4

with the modification

bandicam.2024-04-17.18-33-57-559.mp4

fix: If you try to login without assets. 9145732

prevent this error

bandicam.2024-04-17.18-47-58-431.mp4

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

The modification made to mehah#736 of loadBox was in the wrong place in the code. causes display loadBox in old protocols.
@kokekanon kokekanon changed the title Fix oldprotocol fix: [game_entergame] loadBox in old protocol Apr 17, 2024
@Nottinghster Nottinghster merged commit 6ed18d8 into mehah:main Apr 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants