Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preprint reference to README #85

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add preprint reference to README #85

merged 2 commits into from
Jun 13, 2024

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Jun 11, 2024

Add the robust virtual staining preprint to README, along with some minor edits.

@ziw-liu ziw-liu added the documentation Improvements or additions to documentation label Jun 11, 2024
@ziw-liu ziw-liu requested a review from edyoshikun June 11, 2024 18:12
@ziw-liu ziw-liu mentioned this pull request Jun 11, 2024
Closed
edyoshikun
edyoshikun reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know how were the previous architecture models generated? it might be helpfult to update that image as well.

edyoshikun
edyoshikun approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this LGTM!

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jun 12, 2024

do we know how were the previous architecture models generated? it might be helpfult to update that image as well.

I think they were draw by hand. (I took them from the eLife 2020 paper).

@ziw-liu ziw-liu merged commit 7f656e1 into main Jun 13, 2024
3 checks passed
@ziw-liu ziw-liu deleted the readme-preprint branch June 13, 2024 00:10
edyoshikun pushed a commit that referenced this pull request Jun 18, 2024
@ziw-liu @edyoshikun
Add preprint reference to README (#85)
ae3f667 
* add reference and minor edits

* add back abstracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyoshikun edyoshikun edyoshikun approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.2.0 release - DL@MBL exercise
Development

Successfully merging this pull request may close these issues.
2 participants
@ziw-liu @edyoshikun