Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale metadata handling for positions #93

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Scale metadata handling for positions #93

merged 1 commit into from
Jun 20, 2024

Conversation

edyoshikun
Copy link
Contributor

This PR fixes the bug for the scale_metadata to retrieve the scale metadata if the input is a Positions or Plate level.

Copy link
Collaborator

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edyoshikun edyoshikun merged commit 6a3457e into main Jun 20, 2024
4 checks passed
@edyoshikun edyoshikun deleted the fix_scale_meta branch June 20, 2024 22:12
ziw-liu added a commit that referenced this pull request Jun 24, 2024
* first pass on VSCyto2D demo

* bumping to cellpose 3 (#92)

* adding fix for the scale metadata to handle positions as well. (#93)

* adding the working example. pending missing comments.

* adding vscyto3d example

* adding readme

* minor typo on readme.md

* updating scripts to show the experimental fluorescence and adding the neuromast inference demo.

* adding nueromast demo

* touch README

* update paths for vscyto2d

* update paths for vscyto3d

* update paths for vsneuromast

* use new artifact name

* adding plotting function.

---------

Co-authored-by: Ziwen Liu <ziwen.liu@czbiohub.org>
edyoshikun added a commit that referenced this pull request Jun 29, 2024
* first pass on VSCyto2D demo

* bumping to cellpose 3 (#92)

* adding fix for the scale metadata to handle positions as well. (#93)

* adding the working example. pending missing comments.

* adding vscyto3d example

* adding readme

* minor typo on readme.md

* updating scripts to show the experimental fluorescence and adding the neuromast inference demo.

* adding nueromast demo

* touch README

* update paths for vscyto2d

* update paths for vscyto3d

* update paths for vsneuromast

* use new artifact name

* adding plotting function.

---------

Co-authored-by: Ziwen Liu <ziwen.liu@czbiohub.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants