Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme figure #141

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Fix readme figure #141

merged 4 commits into from
Jul 26, 2023

Conversation

talonchandler
Copy link
Collaborator

Fixes #106.

Here I've added a single 400 dpi .png with a white background.

I tried a raw .svg, but the file was larger, and I wasn't happy with the scaling behavior.

This .png has a white background, so it is legible in all themes.

I have a soft preference for a single fixed white background figure instead of maintaining two versions of the same figure (I think converting this to a black background will require more care than a global filter...some lines should be inverted, but some shouldn't), but I'm open to your preferences/suggestions.

Copy link
Contributor

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@talonchandler talonchandler merged commit 8463155 into main Jul 26, 2023
3 checks passed
@talonchandler talonchandler deleted the fix-readme-figure branch August 5, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README figure is low-res and transparent
2 participants