Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]Go Report Card #98

Closed
meian opened this issue Feb 7, 2022 · 3 comments · Fixed by #122
Closed

[Proposal]Go Report Card #98

meian opened this issue Feb 7, 2022 · 3 comments · Fixed by #122
Labels
environment For environment improvement Some improvement

Comments

@meian
Copy link
Owner

meian commented Feb 7, 2022 •
edited
Loading

Proposal.

Apply Go Report Card in CI.

What benefit with the proposal?

Ensuring a certain level of code quality by various static analyzes.

Others
@meian meian added the improvement Some improvement label Feb 7, 2022
@meian meian changed the title [Proposal]Go ReportCard [Proposal]Go Report Card Feb 7, 2022
@meian meian added the environment For environment label Feb 7, 2022
@meian
Copy link
Owner Author

meian commented Mar 20, 2022

Go Report Cardがアクセスできない？
もしサービス自体が死んでるなら他のを探すので一旦後で

@meian
Copy link
Owner Author

meian commented Mar 21, 2022

https://goreportcard.com/report/github.com/meian/gcf
一時的なサービス障害だったようでアクセスできた。

gofmtとineffassignがgenerics構文解析できてないので1.18対応終わってなさそう？
その分でスコア下げてももったいないので今は対応しない

@meian
Copy link
Owner Author

meian commented Sep 7, 2022

個々のサービスが1.18に対応してきたので再開

@meian meian mentioned this issue Sep 7, 2022
Merged
3 tasks
meian added a commit that referenced this issue Sep 7, 2022
@meian
#98 Add Go Report Card badge to README
47b68ee
@meian meian closed this as completed in #122 Sep 7, 2022
meian added a commit that referenced this issue Sep 7, 2022
@meian
Merge pull request #122 from meian/98-go-report-card
bd47748 
#98 Go Report Card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
environment For environment improvement Some improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#98 Go Report Card meian/gcf
1 participant
@meian