Regularly check for kVariant updates #192
Conversation
Add a workflow that checks if there are any updates to the kVariants dictionary mirrored from https://github.com/hfhchan/irg and in such case submit a PR. Schedule it to run at 10:00 every Monday but also allow it to be triggered manually. Closes meilisearch#185.
|
Hello @goodhoko, so we have to add a CI env var named MEILI_BOT_GH_PAT, that has the writing access on this repository, am I right? |
|
@ManyTheFish Sorry I should've mention this in the PR description. I took the variable from the other workflow that alters the repo so I assumed it could (and should) be used in this workflow as well. Though, it's not strictly necessary to use a custom access token. If you enable the "Allow GitHub Actions to create and approve pull requests" option at the very bottom of the Actions settings the |
| @@ -0,0 +1,29 @@ | |||
| name: Check for kVariants updates | |||
There was a problem hiding this comment.
It does not look like a CI check to me, but more a CI that updates the dictionaries.
I would also add a comment to describe the CI, like "Create a PR update the dictionaries if a changes has been found" (for example)
There was a problem hiding this comment.
@curquiza Just pushed a fixup commit that should address both of your remarks. 🙌
|
Build succeeded: |
Related issue: #185
Add a workflow that checks if there are any updates to the kVariants dictionary mirrored from https://github.com/hfhchan/irg and in such case submit a PR.
Schedule it to run at 10:00 every Monday but also allow it to be triggered manually.
An example of a run can be seen here and the resulting (testing) PR over here (note: the diff set is empty because the artificial change I introduced for testing has since been reverted).
Closes #185.