Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swedish recomposition normalizer and link it to a feature #287

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add swedish recomposition normalizer and link it to a feature #287

merged 1 commit into from
Apr 30, 2024

Conversation

ManyTheFish
Copy link
Member

Pull Request

  • Add a Swedish normalizer, avoiding the diacritic removal from the letter, and preserving the expected Swedish character ordering.
  • Add a feature flag for it (not enabled by default)
  • Trigger test in the CI

Kerollmops
Kerollmops approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work 👏
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Apr 30, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit d970d91 into main Apr 30, 2024
4 checks passed
@meili-bors meili-bors bot deleted the add-swedish-feature-flag branch April 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManyTheFish @Kerollmops