Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force vendoring of LMDB #136

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Force vendoring of LMDB #136

merged 1 commit into from
Nov 14, 2022

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Nov 14, 2022 •
edited
Loading

Pull Request

Related issue

Related to meilisearch/meilisearch#3017: will fix once ported to milli and meilisearch.

What does this PR do?

  • use the new vendored feature of lmdb-sys
  • bump heed/Cargo.toml to v0.12.3v0.12.4

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Kerollmops
Kerollmops approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃

@dureuill dureuill merged commit 7a4542b into v0.12 Nov 14, 2022
@dureuill dureuill deleted the add_vendored branch November 14, 2022 16:13
@Kerollmops Kerollmops mentioned this pull request Nov 17, 2022
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dureuill @Kerollmops