pass lints #35
pass lints #35
Conversation
|
Clément, this p.r. simply has changes from running the default rustfmt, as well as implementing the changes required for all clippy lints/warnings to pass. Your test suite appears to pass. I'm not yet 100% confident in the results, however. Your further review appreciated. |
| @@ -148,7 +148,7 @@ impl PolyDatabase { | |||
| /// # Ok(()) } | |||
| /// ``` | |||
| pub fn get<'a, 'txn, T, KC, DC>( | |||
| &self, | |||
| self, | |||
There was a problem hiding this comment.
I believe all those &self into self changes comes from the trivially_copy_pass_by_ref clippy lint?
I understand that, for performance reason, it could be better to passe self by copy rather than by ref, but I kept all those refs because in future versions of heed the Poly/Database types could be much bigger and could contain more things (like locks). Those were my though but I made a mistake in the process: I annotated those two types with Copy, that is a mistake.
I would prefer not to update the Poly/Database methods for the moment, however all other changes look OK.
There was a problem hiding this comment.
I was thinking the same thing. Perhaps some types should not be Copy?
| @@ -129,8 +131,9 @@ impl EnvOpenOptions { | |||
| /// assert_eq!(ret, Some(5)); | |||
| /// # Ok(()) } | |||
| /// ``` | |||
| /// # Safety | |||
There was a problem hiding this comment.
This title as automatically been added by clippy but you forgot to add some content.
It could be great if you tell the user that it is unsafe to use unsafe flags of LMDB (i.e. MdbNoSync, MdbNoMetaSync, MdbNoLock and more).
|
Closing because it has been fixed since. However, thank you fro the help 😊 |
No description provided.