Apply upstream fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should hopefully shut coverity up
It also contains the cacheflush function declaration.
…lly putting them in a separate section
32 was chosen for page size of 4KB. Not large nough for 16KB pages.
fakepage pointers are only guaranteed to be 2-byte aligned. Use a 2-byte aligned struct definition when referencing 2-byte page members if a page pointer possibly points to a fakepage.
It was an issue to keep the pages in a chained cache list, it was growing a lot and consumming a lot of memory. The only way to free this chained list was to close the environment, this solution was a little bit too much, so we now entirely skip the cache and let malloc to that for us, by itself.
dureuill
approved these changes
Dec 6, 2022
bors bot
added a commit
to meilisearch/lmdb-rs
that referenced
this pull request
Dec 7, 2022
12: Bump the LMDB submodule r=Kerollmops a=Kerollmops This PR bumps the LMDB submodule to bring the fixes of [ITS #9806](https://bugs.openldap.org/show_bug.cgi?id=9806) plus our patches. Related to meilisearch/lmdb#1. Co-authored-by: Kerollmops <clement@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 7, 2022
3210: Fix `MDB_PAGE_FULL` by bumping LMDB r=Kerollmops a=Kerollmops This PR fixes #3062 by upgrading LMDB to the latest version. The changes were made in meilisearch/lmdb#1 and meilisearch/lmdb-rs#12. As heed directly depends on the latest main commit of https://github.com/meilisearch/lmdb-rs, we can bump the `lmdb-rkv-sys` dependency in the Meilisearch _Cargo.lock_ by doing a: ``` cargo update -p lmdb-rkv-sys ``` Co-authored-by: Kerollmops <clement@meilisearch.com>
|
Hi, I'm not a collaborator of meilisearch/lmdb, so I'm not allowed to crate pull requests for this repo. But I think we should apply upstream LMDB fixes. Pull RequestRelated issueFixes ITS#10095, ITS#10095, ITS#9961 What does this PR do?Keep up-to-date with upstream LMDB source code. I recently encountered the bug: ITS#8447 fix The new data item content(value) is interleaved with its previous data, which causes the new value corrupted. See full thread: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the commits from upstream and moves our patches (the last two) on top of it. We wanted ITS #9806 to be fixed, and it is now!
This PR is related to meilisearch/meilisearch#3062.