Add swap indexes api for v0.30.0 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
approved these changes
Feb 22, 2023
| @@ -201,6 +202,37 @@ public void testDeleteIndex() throws Exception { | |||
| assertThrows(MeilisearchApiException.class, () -> client.getIndex(indexUid)); | |||
| } | |||
|
|
|||
| /** Test swapIndexes */ | |||
| @Test | |||
| public void testSwapIndexes() throws Exception { | |||
There was a problem hiding this comment.
I appreciate the effort to test it, but it could be more straightforward. Just the assertion to make sure you could request using the correct indexes and retrieve the type of the task indexSwap would have been ok.
There was a problem hiding this comment.
I knew you were going to say that when I wrote the test but I couldn't help myself 🤭
alallema
force-pushed
the
swap_indexes
branch
from
7e816f4
to
5696e70
Compare
bors bot
added a commit
that referenced
this pull request
Feb 27, 2023
482: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Done: - #544 - #545 - #546 - #547 - #548 - #554 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Feb 27, 2023
553: Update version for the next release (v0.11.0) r=alallema a=meili-bot This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes(#382). ##⚠️ Breaking changes * Add a builder for `SearchRequest` class (#543) `@alallema` - The search method can now only be instantiated: ```java SearchResult search(String q) Searchable search(SearchRequest searchRequest) ``` * Parameters on `getTasks` name changes: #390 - `status` -> `statuses` - `indexUID` -> `indexUIDS` - `type` -> `types` * New `pagination` strategy with the search parameters `page` and `hitsPerPage` #546 - `public Searchable search(SearchRequest searchRequest)` method now return `Searchable` which can be extended to two different classes of results `SearchResult` and `SearchResultPaginated` - `SearchResult` is now an extended class of `Searchable` - Creation of the `SearchResultPaginated` class to handle pagination results from search - Creation of a common search result class `Searchable` ## 🚀 Enhancements * Implement `getRawIndexes` with query parameters (#558) `@oraliahdz` * New filters on `setTasks`: `uid`, `beforeEnqueuedAt`, `afterEnqueuedAt`, ... see #544 * New `client.cancelTasks` method that lets you cancel `enqueued` and `processing` tasks #547 * New `client.deleteTasks` method that lets you delete tasks #548 * New `client.swapIndexes` method that lets you swap two indexes #554 * New fields on `TaskDetails` and modification of ``TaskInfo` #545 ## 🐛 Bug Fixes * Fix: #550 Add a constructor to initialize HttpClient using Gson by default (#551) `@gpor0` * Fix matching strategy enum usage and add test (#561) `@alallema` Thanks again to `@alallema,` `@gpor0` and `@oraliahdz!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification
SWAP INDEXES
swapIndexesParamstypeswapIndexesmethod in the clientswapsin task details