Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getRawIndexes with query parameters #558

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

oraliahdz
Copy link
Contributor

Pull Request

Related issue

Fixes #521

What does this PR do?

  • Implement overload method on getRawIndexes for accepting query parameters
  • Add test for getRawIndexes with params

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema previously approved these changes Feb 23, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oraliahdz, for this PR! ❤️ And congratulations for your first PR on Java Library 🎉
I took the liberty of making an addition to the tests.

@alallema alallema changed the title 521 - getRawIndexes with query parameters Implement getRawIndexes with query parameters Feb 23, 2023
@alallema alallema added the enhancement New feature or request label Feb 23, 2023
@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 23, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@bors bors bot merged commit 99da85e into meilisearch:main Feb 23, 2023
@oraliahdz oraliahdz deleted the 521-overload-getRawIndexes branch February 23, 2023 21:24
bors bot added a commit that referenced this pull request Feb 27, 2023
553: Update version for the next release (v0.11.0) r=alallema a=meili-bot

This version makes this package compatible with Meilisearch v0.30.0 🎉
Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes(#382).

## ⚠️ Breaking changes

* Add a builder for `SearchRequest` class (#543) `@alallema`
   - The search method can now only be instantiated:
   ```java
      SearchResult search(String q)
      Searchable search(SearchRequest searchRequest)
   ```
* Parameters on `getTasks` name changes: #390
   - `status` -> `statuses`
   - `indexUID` -> `indexUIDS`
   - `type` -> `types`
* New `pagination` strategy with the search parameters `page` and `hitsPerPage` #546
   - `public Searchable search(SearchRequest searchRequest)` method now return `Searchable` which can be extended to two different classes of results `SearchResult` and `SearchResultPaginated`
   - `SearchResult` is now an extended class of `Searchable`
   - Creation of the `SearchResultPaginated` class to handle pagination results from search
   - Creation of a common search result class `Searchable`

## 🚀 Enhancements

* Implement `getRawIndexes` with query parameters (#558) `@oraliahdz`
* New filters on `setTasks`: `uid`, `beforeEnqueuedAt`, `afterEnqueuedAt`, ... see #544
* New `client.cancelTasks` method that lets you cancel `enqueued` and `processing` tasks #547
* New `client.deleteTasks` method that lets you delete tasks #548
* New `client.swapIndexes` method that lets you swap two indexes #554 
* New fields on `TaskDetails` and modification of ``TaskInfo` #545

## 🐛 Bug Fixes

* Fix: #550 Add a constructor to initialize HttpClient using Gson by default (#551) `@gpor0`
* Fix matching strategy enum usage and add test (#561) `@alallema`

Thanks again to `@alallema,` `@gpor0` and `@oraliahdz!` 🎉



Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement overload method on getRawIndexes for accepting query parameters
2 participants