Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel task api for v0.30.0 #547

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

alallema
Copy link
Contributor

Add the cancel task api see spec: meilisearch/specifications#195

  • Implement CancelTasks() in the client
    • params: CancelTasksQuery
    • returns: TaskInfo
  • Tests cancelation on query parameters

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uids is missing in the final URL! The rest is perfect 🍐

alallema and others added 3 commits February 16, 2023 15:13
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@alallema alallema merged commit a498166 into bump-meilisearch-v0.30.0 Feb 16, 2023
@alallema alallema deleted the add_cancel_task_api_for_v0.30.0 branch February 16, 2023 14:15
@alallema alallema added the enhancement New feature or request label Feb 21, 2023
bors bot added a commit that referenced this pull request Feb 27, 2023
482: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#221

This PR:
- gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.30.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._

Done:
- #544 
- #545 
- #546 
- #547 
- #548 
- #554 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
bors bot added a commit that referenced this pull request Feb 27, 2023
553: Update version for the next release (v0.11.0) r=alallema a=meili-bot

This version makes this package compatible with Meilisearch v0.30.0 🎉
Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes(#382).

## ⚠️ Breaking changes

* Add a builder for `SearchRequest` class (#543) `@alallema`
   - The search method can now only be instantiated:
   ```java
      SearchResult search(String q)
      Searchable search(SearchRequest searchRequest)
   ```
* Parameters on `getTasks` name changes: #390
   - `status` -> `statuses`
   - `indexUID` -> `indexUIDS`
   - `type` -> `types`
* New `pagination` strategy with the search parameters `page` and `hitsPerPage` #546
   - `public Searchable search(SearchRequest searchRequest)` method now return `Searchable` which can be extended to two different classes of results `SearchResult` and `SearchResultPaginated`
   - `SearchResult` is now an extended class of `Searchable`
   - Creation of the `SearchResultPaginated` class to handle pagination results from search
   - Creation of a common search result class `Searchable`

## 🚀 Enhancements

* Implement `getRawIndexes` with query parameters (#558) `@oraliahdz`
* New filters on `setTasks`: `uid`, `beforeEnqueuedAt`, `afterEnqueuedAt`, ... see #544
* New `client.cancelTasks` method that lets you cancel `enqueued` and `processing` tasks #547
* New `client.deleteTasks` method that lets you delete tasks #548
* New `client.swapIndexes` method that lets you swap two indexes #554 
* New fields on `TaskDetails` and modification of ``TaskInfo` #545

## 🐛 Bug Fixes

* Fix: #550 Add a constructor to initialize HttpClient using Gson by default (#551) `@gpor0`
* Fix matching strategy enum usage and add test (#561) `@alallema`

Thanks again to `@alallema,` `@gpor0` and `@oraliahdz!` 🎉



Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants