Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in README.md #1582

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix broken link in README.md #1582

merged 1 commit into from
Sep 20, 2023

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Sep 19, 2023

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cfd27e6) 97.25% compared to head (9cc63c2) 97.25%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          22       22           
  Lines         765      765           
  Branches      108      108           
=======================================
  Hits          744      744           
  Misses         20       20           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕

bors merge

meili-bors bot added a commit that referenced this pull request Sep 20, 2023
1580: Fix code samples (remove useless, and add missing) r=mdubus a=curquiza

I created [scripts to manage code samples](https://github.com/meilisearch/integration-automations/pull/164) (internal only)

I found out the following code samples are still in this repo but not used by the documentation anymore:

```bash
meilisearch-js
- 'documents_guide_add_movie_1' not found in documentation
- 'getting_started_communicating_with_a_protected_instance' not found in documentation
- 'faceted_search_facets_1' not found in documentation
- 'faceted_search_2' not found in documentation
```

And the missing code samples
```
meilisearch-js
- 'getting_started_typo_tolerance' not found
```

I also changed some `"` into `'`

1582: Fix broken link in README.md r=mdubus a=curquiza

Fixes #1581 

Related to: meilisearch/documentation#2566

Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@mdubus
Copy link
Member

mdubus commented Sep 20, 2023

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

Build succeeded:

@curquiza curquiza merged commit 412d9a7 into main Sep 20, 2023
8 checks passed
@curquiza curquiza deleted the curquiza-patch-1 branch September 20, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 on link from README
2 participants