Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded comments from config files #1657

Merged
merged 2 commits into from
May 23, 2024

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented May 23, 2024

Pull Request

What does this PR do?

In #1616 I updated configurations, and left a bunch of explanatory comments that should've been viewed and removed. Maybe this approach wasn't the best, and should've instead commented on the PR, but anyways, lets remove them, they shouldn't have ended up in main branch.

@flevi29 flevi29 requested a review from brunoocasali May 23, 2024 07:25
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (cd61a8c) to head (73b6196).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1657   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          22       22           
  Lines         858      858           
  Branches       93       86    -7     
=======================================
  Hits          836      836           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flevi29 flevi29 merged commit 6cd64e9 into meilisearch:main May 23, 2024
6 checks passed
@flevi29 flevi29 deleted the remove-config-comments branch May 23, 2024 11:31
@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants