-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken CI after rubocop upgrade #381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.36.0...v1.37.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
brunoocasali
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THAANK YOU!
bors merge
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
meili-bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
401: Update version for the next release (v0.21.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - Add `MeilisearchClient#cancel_tasks` (#392) `@brunoocasali` - Add `MeilisearchClient#swap_indexes` (#393) `@brunoocasali` - Add `MeilisearchClient#delete_tasks` (#394) `@brunoocasali` - Add support to finite pagination by using `page` and `hits_per_page` like `index.search('', { page: 1, hits_per_page: 10 })` - Add filters for tasks resources (#391) `@brunoocasali` - `uids` filter parameter for `MeilisearchClient#get_tasks({ uids: [1, 2, 3] })` - `canceled_by` filter parameter for `MeilisearchClient#get_tasks({ canceled_by: [99, 100]})` - `before_enqueued_at` and `after_enqueued_at` filter parameter for `MeilisearchClient#get_tasks({ before_enqueued_at: DateTime.new(2022), after_enqueued_at: '2022-01-20' })` - `before_finished_at` and `after_finished_at` filter parameter for `MeilisearchClient#get_tasks({ before_finished_at: DateTime.new(2022), after_finished_at: '2022-01-20' })` - `before_started_at` and `after_started_at` filter parameter for `MeilisearchClient#get_tasks({ before_started_at: DateTime.new(2022), after_started_at: '2022-01-20' })` ##⚠️ Breaking Changes - Update filters for tasks resources (#391) `@brunoocasali` - `index_uid` query parameter is renamed `index_uids` when querying `MeilisearchClient#get_tasks` - `type` query parameter is renamed `types` when querying `MeilisearchClient#get_tasks` - `status` query parameter is renamed `statuses` when querying `MeilisearchClient#get_tasks` ## 💅 Misc * Fix broken CI after rubocop upgrade (#381) `@jonatanrdsantos` * Add new code-samples for matching_strategy (#384) `@thicolares` * Improve indexes names in tests (#385) `@thicolares` Thanks again to `@brunoocasali,` `@dibashthapa,` `@jonatanrdsantos,` and `@thicolares!` 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broke CI #380