Add update filter for tasks #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
added
the
breaking-change
mdubus
reviewed
Nov 15, 2022
| @@ -50,16 +50,35 @@ | |||
| expect(tasks['next']).to be_a(Integer) | |||
| end | |||
|
|
|||
| it 'filters tasks with index_uid/type/status' do | |||
| tasks = client.tasks(index_uid: ['a-cool-index-name']) | |||
| it 'filters tasks with index_uidx/typex/statuses' do | |||
There was a problem hiding this comment.
Is it intended to have typex instead of types, and index_uidx instead of index_uids?
There was a problem hiding this comment.
No, it was a mistake, thanks for catching that! :D
brunoocasali
commented
Nov 15, 2022
curquiza
approved these changes
Nov 16, 2022
brunoocasali
deleted the
bump-meilisearch-v0.30.0-add-update-filter-for-tasks
branch
meili-bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
401: Update version for the next release (v0.21.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - Add `MeilisearchClient#cancel_tasks` (#392) `@brunoocasali` - Add `MeilisearchClient#swap_indexes` (#393) `@brunoocasali` - Add `MeilisearchClient#delete_tasks` (#394) `@brunoocasali` - Add support to finite pagination by using `page` and `hits_per_page` like `index.search('', { page: 1, hits_per_page: 10 })` - Add filters for tasks resources (#391) `@brunoocasali` - `uids` filter parameter for `MeilisearchClient#get_tasks({ uids: [1, 2, 3] })` - `canceled_by` filter parameter for `MeilisearchClient#get_tasks({ canceled_by: [99, 100]})` - `before_enqueued_at` and `after_enqueued_at` filter parameter for `MeilisearchClient#get_tasks({ before_enqueued_at: DateTime.new(2022), after_enqueued_at: '2022-01-20' })` - `before_finished_at` and `after_finished_at` filter parameter for `MeilisearchClient#get_tasks({ before_finished_at: DateTime.new(2022), after_finished_at: '2022-01-20' })` - `before_started_at` and `after_started_at` filter parameter for `MeilisearchClient#get_tasks({ before_started_at: DateTime.new(2022), after_started_at: '2022-01-20' })` ##⚠️ Breaking Changes - Update filters for tasks resources (#391) `@brunoocasali` - `index_uid` query parameter is renamed `index_uids` when querying `MeilisearchClient#get_tasks` - `type` query parameter is renamed `types` when querying `MeilisearchClient#get_tasks` - `status` query parameter is renamed `statuses` when querying `MeilisearchClient#get_tasks` ## 💅 Misc * Fix broken CI after rubocop upgrade (#381) `@jonatanrdsantos` * Add new code-samples for matching_strategy (#384) `@thicolares` * Improve indexes names in tests (#385) `@thicolares` Thanks again to `@brunoocasali,` `@dibashthapa,` `@jonatanrdsantos,` and `@thicolares!` 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/Update filters for
/tasksAdd filters for this endpoint:
uidsfilter. e.g/tasks?uids=1,2,3,4canceledByfilter. e.g/tasks?canceledBy=99,100beforeEnqueuedAtandafterEnqueuedAt. e.g/tasks?afterEnqueuedAt=2022-01-20&beforeEnqueuedAt=2022-01-23beforeStartedAtandafterStartedAt. e.g/tasks?afterStartedAt=2022-01-20&beforeStartedAt=2022-01-23beforeFinishedAtandafterFinishedAt. e.g/tasks?afterFinishedAt=2022-01-20&beforeFinishedAt=2022-01-23Rename filters and error codes for this endpoint:
indexUidquery parameter is renamedindexUidstypequery parameter is renamedtypesstatusquery parameter is renamedstatuses