Improve indexes names in tests #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thicolares
force-pushed
the
improve-index-names-in-tests
branch
from
3012cad
to
d7ada48
Compare
| @@ -2,11 +2,11 @@ | |||
|
|
|||
| RSpec.describe MeiliSearch::Index do | |||
| it 'fetch the info of the index' do | |||
| client.create_index!('new_index') | |||
There was a problem hiding this comment.
We also have some unclear names in the indexes_spec.rb and documents_spec.rb, can you update them as well?
There was a problem hiding this comment.
@brunoocasali good call! It's done! ✅
thicolares
commented
Oct 31, 2022
|
|
||
| indexes = client.indexes(limit: 1, offset: 2) | ||
|
|
||
| expect(indexes['results']).to be_a(Array) | ||
| expect(indexes['total']).to eq(3) | ||
| expect(indexes['limit']).to eq(1) | ||
| expect(indexes['offset']).to eq(2) | ||
| expect(indexes['results'].map(&:uid)).to eq(['third_index']) | ||
| expect(indexes['results'].map(&:uid)).to eq(['colors']) |
There was a problem hiding this comment.
This looks strange but is correct. Apparently, we sort this before returning and the last one, in this case, is colors. third_index was also the third by coincidence 😉
thicolares
force-pushed
the
improve-index-names-in-tests
branch
from
261636e
to
1fe584b
Compare
brunoocasali
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Thanks a lot for your contribution @thicolares ❤️ 🇧🇷
bors merge
|
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
brunoocasali
added
enhancement
meili-bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
401: Update version for the next release (v0.21.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - Add `MeilisearchClient#cancel_tasks` (#392) `@brunoocasali` - Add `MeilisearchClient#swap_indexes` (#393) `@brunoocasali` - Add `MeilisearchClient#delete_tasks` (#394) `@brunoocasali` - Add support to finite pagination by using `page` and `hits_per_page` like `index.search('', { page: 1, hits_per_page: 10 })` - Add filters for tasks resources (#391) `@brunoocasali` - `uids` filter parameter for `MeilisearchClient#get_tasks({ uids: [1, 2, 3] })` - `canceled_by` filter parameter for `MeilisearchClient#get_tasks({ canceled_by: [99, 100]})` - `before_enqueued_at` and `after_enqueued_at` filter parameter for `MeilisearchClient#get_tasks({ before_enqueued_at: DateTime.new(2022), after_enqueued_at: '2022-01-20' })` - `before_finished_at` and `after_finished_at` filter parameter for `MeilisearchClient#get_tasks({ before_finished_at: DateTime.new(2022), after_finished_at: '2022-01-20' })` - `before_started_at` and `after_started_at` filter parameter for `MeilisearchClient#get_tasks({ before_started_at: DateTime.new(2022), after_started_at: '2022-01-20' })` ##⚠️ Breaking Changes - Update filters for tasks resources (#391) `@brunoocasali` - `index_uid` query parameter is renamed `index_uids` when querying `MeilisearchClient#get_tasks` - `type` query parameter is renamed `types` when querying `MeilisearchClient#get_tasks` - `status` query parameter is renamed `statuses` when querying `MeilisearchClient#get_tasks` ## 💅 Misc * Fix broken CI after rubocop upgrade (#381) `@jonatanrdsantos` * Add new code-samples for matching_strategy (#384) `@thicolares` * Improve indexes names in tests (#385) `@thicolares` Thanks again to `@brunoocasali,` `@dibashthapa,` `@jonatanrdsantos,` and `@thicolares!` 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #355
What does this PR do?
booksin all cases seems tedious, but helps keep the same mental context across all tests.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!