New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete_tasks
method
#394
Add delete_tasks
method
#394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨ 🦕
👆 I just don't see all the changes you gave in the PR description like "Add deletedTasks in field details from Task type when performing taskDeletion" -> I guess you have nothing to change in Ruby but it's confusing for a reviewer 😇 Same I don't see any filter addition in this PR |
You're correct @curquiza it was a bad CTRL+C/CTRL+V. But in the filters case, |
e59f737
to
6030ebe
Compare
6030ebe
to
6f920dc
Compare
401: Update version for the next release (v0.21.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - Add `MeilisearchClient#cancel_tasks` (#392) `@brunoocasali` - Add `MeilisearchClient#swap_indexes` (#393) `@brunoocasali` - Add `MeilisearchClient#delete_tasks` (#394) `@brunoocasali` - Add support to finite pagination by using `page` and `hits_per_page` like `index.search('', { page: 1, hits_per_page: 10 })` - Add filters for tasks resources (#391) `@brunoocasali` - `uids` filter parameter for `MeilisearchClient#get_tasks({ uids: [1, 2, 3] })` - `canceled_by` filter parameter for `MeilisearchClient#get_tasks({ canceled_by: [99, 100]})` - `before_enqueued_at` and `after_enqueued_at` filter parameter for `MeilisearchClient#get_tasks({ before_enqueued_at: DateTime.new(2022), after_enqueued_at: '2022-01-20' })` - `before_finished_at` and `after_finished_at` filter parameter for `MeilisearchClient#get_tasks({ before_finished_at: DateTime.new(2022), after_finished_at: '2022-01-20' })` - `before_started_at` and `after_started_at` filter parameter for `MeilisearchClient#get_tasks({ before_started_at: DateTime.new(2022), after_started_at: '2022-01-20' })` ##⚠️ Breaking Changes - Update filters for tasks resources (#391) `@brunoocasali` - `index_uid` query parameter is renamed `index_uids` when querying `MeilisearchClient#get_tasks` - `type` query parameter is renamed `types` when querying `MeilisearchClient#get_tasks` - `status` query parameter is renamed `statuses` when querying `MeilisearchClient#get_tasks` ## 💅 Misc * Fix broken CI after rubocop upgrade (#381) `@jonatanrdsantos` * Add new code-samples for matching_strategy (#384) `@thicolares` * Improve indexes names in tests (#385) `@thicolares` Thanks again to `@brunoocasali,` `@dibashthapa,` `@jonatanrdsantos,` and `@thicolares!` 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
DELETE /tasks
GET /tasks
minus from and limit are available.uids
filter. e.g/tasks?uids=1,2,3,4
(invalid_task_uids_filter
canceledBy
filter. e.g/tasks?canceledBy=99,100
invalid_task_canceled_by_filter
beforeEnqueuedAt
andafterEnqueuedAt
. e.g/tasks?afterEnqueuedAt=2022-01-20&beforeEnqueuedAt=2022-01-23
beforeStartedAt
andafterStartedAt
. e.g/tasks?afterStartedAt=2022-01-20&beforeStartedAt=2022-01-23
beforeFinishedAt
andafterFinishedAt
. e.g/tasks?afterFinishedAt=2022-01-20&beforeFinishedAt=2022-01-23