Use download latest script in CI #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
Incredible! It has worked the first time: (I re-run the workflow) But now, it does not! |
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
|
@bidoubiwa looks like the CI works now 🎉 |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Oct 19, 2021
1822: Tiny improvements in download-latest.sh r=irevoire a=curquiza - Add check on `$latest` to check if it's empty. We have some issue on the swift SDK currently where the version number seems not to be retrieved, but we don't why meilisearch/meilisearch-swift#216 - Replace some `"` by `'` - Rename `$BINARY_NAME` by `$binary_name` to make them consistent with the other variables that are filled all along the script Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bidoubiwa
added
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since meilisearch/meilisearch#1655 has been fixed into the
download-latest.shscript, we can use it in the CI