Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Index name parsing error message to fit the specification #3032

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix Index name parsing error message to fit the specification #3032

merged 1 commit into from
Nov 8, 2022

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Nov 8, 2022 •
edited
Loading

fixes #2924

@ManyTheFish ManyTheFish force-pushed the fix-index-parsing-error-message branch from e3f2934 to 6e893a4 Compare November 8, 2022 15:29
@curquiza
Copy link
Member

curquiza commented Nov 8, 2022

@ManyTheFish looks like GitHub does not like us, despite you add fixes #... in your PR description, can you check the issues you fix are well added to the Development section of the PRs you open please? 😇

@curquiza curquiza added this to the v0.30.0 milestone Nov 8, 2022
@ManyTheFish ManyTheFish force-pushed the fix-index-parsing-error-message branch from 6e893a4 to 8bb260b Compare November 8, 2022 15:36
Kerollmops
Kerollmops approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great on my side, thank you!
bors merge

@ManyTheFish ManyTheFish linked an issue Nov 8, 2022 that may be closed by this pull request
Wrong variant returned for invalid_api_key_indexes error when creating an API key. #2924
Closed
@bors
Copy link
Contributor

bors bot commented Nov 8, 2022

Build succeeded:

@bors bors bot merged commit 1d5f17a into release-v0.30.0 Nov 8, 2022
@bors bors bot deleted the fix-index-parsing-error-message branch November 8, 2022 16:25
@ManyTheFish ManyTheFish mentioned this pull request Nov 8, 2022
Closed
@meili-bot meili-bot added the v0.30.0 PRs/issues solved in v0.30.0 released on 2022-11-28 label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
v0.30.0 PRs/issues solved in v0.30.0 released on 2022-11-28
Projects
None yet
Milestone
v0.30.0
Development

Successfully merging this pull request may close these issues.

Wrong variant returned for invalid_api_key_indexes error when creating an API key.
4 participants
@ManyTheFish @curquiza @Kerollmops @meili-bot