This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Transfer numbers and strings facets into the appropriate facet databases #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
split-facet-databases
branch
from
871c37e
to
2b998dd
Compare
Closed
Kerollmops
requested review from
ManyTheFish and
MarinPostma
and removed request for
ManyTheFish
Kerollmops
force-pushed
the
split-facet-databases
branch
from
2b998dd
to
5012cc3
Compare
|
bors try |
tryBuild succeeded: |
ManyTheFish
suggested changes
May 31, 2021
|
bors try |
tryBuild succeeded: |
ManyTheFish
approved these changes
May 31, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #152 and changes the layout of the facets values, numbers and strings are now in dedicated databases and the user no more needs to define the type of the fields. No more conversion between the two types is done, numbers (floats and integers converted to f64) go to the facet float database and strings go to the strings facet database.
There is one related issue that I found regarding CSVs, the values in a CSV are always considered to be strings, meilisearch/specifications#28 fixes this issue by allowing the user to define the fields types using
:in the "CSV Formatting Rules" section.All previous tests on facets have been modified to pass again and I have also done hand-driven tests with the 115m songs dataset. Everything seems to be good!
Fixes #192.