Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Categorize the os error codes 5 and 28 as storage full user errors #580

Closed
wants to merge 1 commit into from

Conversation

Kerollmops
Copy link
Member

This PR is related to meilisearch/meilisearch#2255 and correctly categorizes the os error codes 5 and 28 as a UserError::NoSpaceLeftOnDevice error. We will display the message: There is no more space left on the device. Consider increasing the size of the disk/partition when we encounter one of those two os error codes.

@Kerollmops Kerollmops requested a review from irevoire July 6, 2022 09:21
@Kerollmops Kerollmops added no breaking The related changes are not breaking (DB nor API) enhancement New feature or request API breaking The related changes break the milli API and removed no breaking The related changes are not breaking (DB nor API) labels Jul 6, 2022
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curquiza
Copy link
Member

curquiza commented Sep 8, 2022

@ManyTheFish
Copy link
Member

ManyTheFish commented Oct 17, 2022

Hey @curquiza, the error code can't be returned by Meilisearch directly but could come from milli, but milli never uses this error, so this error code is never returned.
However, there are some ways that an Internal Error could be returned with a message containing something equivalent to no space left on device, we write in a file at least during the snapshot and dump process when writing the snapshot/dump, and the indexing process via grenad. Unfortunately, there is no specialized error variant equivalent to our no_space_left_on_device so far, making it difficult to bind the error.

note that LMDB will not return a such error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API breaking The related changes break the milli API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants