Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Remove unused infos, http-ui, and milli/fuzz, crates #636

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Remove unused infos, http-ui, and milli/fuzz, crates #636

merged 1 commit into from
Sep 14, 2022

Conversation

loiclec
Copy link
Contributor

@loiclec loiclec commented Sep 13, 2022

We haven't used the infos/, http-ui/ and milli/fuzz/ crates in a long time. They are not properly maintained and probably do not work correctly anymore.

This PR removes these crates entirely from the workspace to reduce the amount of code we need to maintain.

@loiclec loiclec added no breaking The related changes are not breaking (DB nor API) maintenance Issue about maintenance (CI, tests, refacto...) labels Sep 13, 2022
irevoire
irevoire previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad but nice

ManyTheFish
ManyTheFish previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, http-ui is not necessary for me.
We can merge this!

Kerollmops
Kerollmops previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no more use any of those binaries, you can merge!

@curquiza
Copy link
Member

Bye bye pretty crates 🦀

irevoire
irevoire approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

ManyTheFish
ManyTheFish approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 14, 2022

Build succeeded:

@bors bors bot merged commit d94339a into main Sep 14, 2022
@bors bors bot deleted the remove-unused-crates branch September 14, 2022 13:03
@loiclec loiclec mentioned this pull request Sep 21, 2022
Merged
bors bot added a commit that referenced this pull request Sep 21, 2022
@bors
Merge #641
e1e025c 
641: Remove `helpers` crate r=Kerollmops a=loiclec

# Pull Request

## What does this PR do?
Remove the `helpers` crates, because (I think) we don't use it. This should have been part of #636 , but I forgot about it then :)





Co-authored-by: Loïc Lecrenier <loic@meilisearch.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@irevoire irevoire irevoire approved these changes

@ManyTheFish ManyTheFish ManyTheFish approved these changes

@Kerollmops Kerollmops Kerollmops left review comments

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loiclec @curquiza @Kerollmops @ManyTheFish @irevoire