Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

ci: Use pre-compiled binaries for faster CI #685

Merged
merged 1 commit into from
Nov 16, 2022
Merged

ci: Use pre-compiled binaries for faster CI #685

merged 1 commit into from
Nov 16, 2022

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Nov 3, 2022

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@azzamsa azzamsa mentioned this pull request Nov 3, 2022
Closed
@curquiza curquiza linked an issue Nov 7, 2022 that may be closed by this pull request
Use pre-compiled binaries for faster CI #686
Closed
@curquiza curquiza marked this pull request as ready for review November 7, 2022 09:33
curquiza
curquiza approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, thanks for the PR!
But I would rather the @irevoire review before merging

@curquiza curquiza added no breaking The related changes are not breaking (DB nor API) maintenance Issue about maintenance (CI, tests, refacto...) labels Nov 7, 2022
irevoire
irevoire approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's turbo nice; thanks, @azzamsa and sorry for the huge delay. I totally missed your PR 😱

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Build succeeded:

@bors bors bot merged commit a651397 into meilisearch:main Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@curquiza curquiza curquiza approved these changes

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pre-compiled binaries for faster CI
3 participants
@azzamsa @irevoire @curquiza