Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix soft deleted bug settings #690

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Fix soft deleted bug settings #690

merged 2 commits into from
Nov 8, 2022

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Nov 8, 2022 •
edited
Loading

This PR fixes a bug that was triggered by reindexing the documents when changing the settings, we were indexing documents that were soft-deleted instead of ignoring them.

Related to meilisearch/meilisearch#3021 and meilisearch/meilisearch#2945.

@Kerollmops Kerollmops added bug Something isn't working no breaking The related changes are not breaking (DB nor API) labels Nov 8, 2022
ManyTheFish
ManyTheFish suggested changes Nov 8, 2022
View reviewed changes
milli/src/update/settings.rs Outdated Show resolved Hide resolved
This was referenced Nov 8, 2022
Closed
Closed
ManyTheFish
ManyTheFish approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 8, 2022

Build succeeded:

@bors bors bot merged commit 24a298a into main Nov 8, 2022
@bors bors bot deleted the fix-soft-deleted-bug-settings branch November 8, 2022 14:18
@Kerollmops Kerollmops mentioned this pull request Nov 14, 2022
Merged
bors bot added a commit that referenced this pull request Nov 14, 2022
@bors @Kerollmops
Merge #698
cbdcf5e 
698: Fix soft deleted bug settings r=curquiza a=Kerollmops

This PR is a cherry-pick of #690 and bumps the crates version to v0.33.5.

Co-authored-by: Kerollmops <clement@meilisearch.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerollmops @ManyTheFish