-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display attributes with correct capitalization #494
Comments
Thanks |
@curquiza Can you point to the file where this happens? Indeed, it's a good first issue, as it's almost certainly removing something. I looked for :::to_ascii_uppercase but didn't find it. |
Pinging @mdubus when you have time to guide the user please 😊 |
Hey @tacman 👋 Thanks for your interest in this repo 🙏 The file you're looking for is the I guess the way to resolve it would be to override this class to have a Let me know if you have any questions, I'd be happy to help you with it 😊 |
Only Donald Trump thinks that all caps is easier to read. I think the css in type10 should be changed. It appears that the only other place it's used is in the Version string. Personally, I think v1 is easier to read than V1, and in fact it's overwritten there too. I've made a PR that mimics how the version is rendered, but since the only 2 places I can find type10 overrides the text transformation, it would make more sense to remove it in the css. But perhaps these type definitions are used elsewhere. |
@tacman indeed I just checked and it would make more sense to just remove the text-transform from the CSS. Thanks for your help 🙌 🙏 |
Done! |
Description
Attributes are uppercased. It's prettier but it can be confusing. Recently, a free-trial customer was getting 0 search results, because he had copied the searchable attributes from the mini-dashboard.
As @guimachiavelli pointed out:
Expected behavior
Attributes should be shown as they were sent, with the original case.
Current behavior
They are uppercased.
Screenshots or Logs
If applicable, add screenshots or logs to help explain your problem.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: