[#265]: Validator to properly shutdown, so not to fail further invocations on the same JVM process. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t other invocations on the same JVM process.
ibacher
approved these changes
May 20, 2024
| @@ -53,12 +56,15 @@ | |||
| import org.testcontainers.containers.MySQLContainer; | |||
| import ch.vorburger.exec.ManagedProcessException; | |||
|
|
|||
| @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS) | |||
There was a problem hiding this comment.
I'm not sure if this annotation does anything because of how BaseContextSenstitiveTest is defined.
There was a problem hiding this comment.
It actually does, as it forces the recreation of a new Spring application context on the next run. Also BaseContextSenstitiveTest extends AbstractJUnit4SpringContextTests which theoretically means being able to hook into the Spring context life-cycle.
Ruhanga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265