Allow multiple package specs to output in source if they have different suffixes #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoRFS
requested changes
Apr 9, 2021
Comment on lines
+80
to
+81
| let distinct_suffixes = Set_string.cardinal !distinct_suffixes in | ||
| if !has_in_source > distinct_suffixes then |
There was a problem hiding this comment.
I think it is better if we check if there is the needed suffixes instead of looking the cardinality.
Also because we can say suffix X appears two times
|
The dune integration, and ocaml/dune#7193 in particular, allows this. |
anmonteiro
deleted the
anmonteiro/relax-in-source-assumption-for-multiple-suffixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #157.
.jsand.bs.jssuffixes, we'll gladly emit them in source. Couldn't that cause bundlers to include both (copies of the same) modules in the bundled output?