Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3: Signup #3

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Milestone 3: Signup #3

merged 5 commits into from
Feb 1, 2023

Conversation

kusiLaw
Copy link
Collaborator

@kusiLaw kusiLaw commented Jan 31, 2023

Create Signup

  • Add Navbar
  • Add Signup

- group related action to api
- update signup reducers
- add desktop styling with cs
- add placeholder links
- connects the api
- add css
Copy link
Collaborator

@Moathal Moathal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kusiLaw 👏🏽,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. The previous reviewer missed some of them, and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me(@rotimiazeez) in your question so I can receive the notification.


As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@melashu melashu merged commit 2405f3c into working-branch Feb 1, 2023
@AbigiyaTY AbigiyaTY changed the title Signup Milestone 3: Signup Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants